-
Notifications
You must be signed in to change notification settings - Fork 47
chore: Update minimum required python version to 3.10 #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Saad Zaher <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 18281412612Details
💛 - Coveralls |
kramaranya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Please update https://github.com/kubeflow/sdk/blob/main/pyproject.toml#L18
pyproject.toml
Outdated
| name = "kubeflow" | ||
| dynamic = ["version"] | ||
| requires-python = ">=3.9" | ||
| requires-python = ">=3.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we still support 3.10?
cc @andreyvelich @astefanutti
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I would suggest we jump to 3.10 first.
IMO, we should support 3.9 for SDK v0.2 release at least.
The 3.9 EOF is October 2025, and I would imagine we still have users on that version: https://devguide.python.org/versions/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
|
We also need to update Trainer and Katib |
Signed-off-by: Saad Zaher <[email protected]>
|
Shall we move forward with this PR having 0.2.0 been released? cc @szaher @andreyvelich |
What this PR does / why we need it:
python 3.9 EOL is end of October as per https://devguide.python.org/versions/
I suggest we move to python3.11 directly which provides better performance.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #
Checklist: