Skip to content

Conversation

@szaher
Copy link
Member

@szaher szaher commented Oct 6, 2025

What this PR does / why we need it:
python 3.9 EOL is end of October as per https://devguide.python.org/versions/
I suggest we move to python3.11 directly which provides better performance.

image

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):

Fixes #

Checklist:

  • Docs included if any changes are user facing

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@szaher szaher changed the title Update minimum required python version to 3.11 chore: Update minimum required python version to 3.11 Oct 6, 2025
@coveralls
Copy link

coveralls commented Oct 6, 2025

Pull Request Test Coverage Report for Build 18281412612

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.739%

Totals Coverage Status
Change from base Build 18197220384: 0.0%
Covered Lines: 297
Relevant Lines: 414

💛 - Coveralls

Copy link
Contributor

@kramaranya kramaranya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyproject.toml Outdated
name = "kubeflow"
dynamic = ["version"]
requires-python = ">=3.9"
requires-python = ">=3.11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we still support 3.10?
cc @andreyvelich @astefanutti

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I would suggest we jump to 3.10 first.
IMO, we should support 3.9 for SDK v0.2 release at least.
The 3.9 EOF is October 2025, and I would imagine we still have users on that version: https://devguide.python.org/versions/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@kramaranya
Copy link
Contributor

We also need to update Trainer and Katib

Signed-off-by: Saad Zaher <[email protected]>
@szaher szaher changed the title chore: Update minimum required python version to 3.11 chore: Update minimum required python version to 3.10 Oct 8, 2025
@kramaranya
Copy link
Contributor

Shall we move forward with this PR having 0.2.0 been released? cc @szaher @andreyvelich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants