Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Add an 'Always use latest version option' for recurring runs. Fixes #11581 #11628

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muzzlol
Copy link
Contributor

@muzzlol muzzlol commented Feb 14, 2025

Description of your changes:

This change introduces a checkbox in the New Run V2 page that allows users to create recurring runs that always use the latest version of a pipeline, without needing to specify a pipeline version ID.

The changes include:

  • Added a useLatestVersion state variable to track the checkbox's state.
  • Persisted the useLatestVersion preference in localStorage.
  • Modified the pipeline_version_reference in the API payload to only send the pipeline_id when useLatestVersion is enabled.
  • Disabled the pipeline version selector when useLatestVersion is enabled.
  • Implemented a fallback mechanism to update the Run Name when the checkbox is toggled before a pipeline is selected.

Checklist:

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @muzzlol. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@muzzlol muzzlol force-pushed the feat-latest-version-checkbox branch from d74d043 to c09bc4e Compare February 14, 2025 02:13
@HumairAK HumairAK requested review from mprahl and removed request for HumairAK and zijianjoy February 19, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant