feat(ws): Upgrade Go to 1.24 - tensorboard-controller component #755
+11
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
added
the
area/controller
google-oss-prow
bot
added
area/v1
Author
|
/assign @mkoushni |
Signed-off-by: Marina Koushnir <[email protected]>
mkoushni
force-pushed
the
notebooks-v1
branch
from
f510725 to
ab3a5d0
Compare
Signed-off-by: Marina Koushnir <[email protected]>
liavweiss
reviewed
Nov 27, 2025
liavweiss
left a comment
liavweiss
left a comment
There was a problem hiding this comment.
Thank you, Marina. In addition to the review comments, please include the go.sum file in the PR as well.
This file is important for validating module dependencies and ensuring consistent, reproducible builds across different environments.
mkoushni
force-pushed
the
notebooks-v1
branch
from
ea6177c to
93b0e3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR updates the required Go version for the tensorboard-controller component to Go 1.24.x. This change is necessary to maintain compatibility with updated Kubernetes client libraries and ensure the component is built with current, supported security patches.
Changes Made
Updated the go.mod file to specify go 1.24.
Synchronized dependencies via go mod tidy and go mod vendor to lock in compatible library versions (including necessary updates to transitive dependencies like golang.org/x/text, etc.).