feat(ui): add persistent Dark Mode and Light Mode theme toggle - #3211
Open
vjkumar2756 wants to merge 2 commits into
Open
feat(ui): add persistent Dark Mode and Light Mode theme toggle #3211vjkumar2756 wants to merge 2 commits into
vjkumar2756 wants to merge 2 commits into
Conversation
…Models Signed-off-by: Vijay <vjkumar2756@gmail.com>
Signed-off-by: Vijay <vjkumar2756@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
@pboyd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #3210
Summary
This PR adds full Dark Mode & Light Mode theme support to the Kubeflow Hub UI. It introduces a persistent theme switcher in the top navigation header bar, respects OS system preferences (
prefers-color-scheme), and applies a high-contrast Midnight Slate Dark Design System across all UI components.What Changed?
1. New Theme Context (
ThemeContext.tsx)CustomThemeProvidermanaging theme states (light,dark,system).localStoragepersistence under keykubeflow_theme_mode.matchMedia('(prefers-color-scheme: dark)'))..dark-themeand.pf-v6-theme-darkCSS classes ondocument.documentElement.2. Navigation Bar Theme Switcher (
NavBar.tsx)3. Application Root (
App.tsx)<CustomThemeProvider>.4. Custom Dark Theme Styling (
app.css)#0b0f19), surface cards (#111827), borders (#1e293b).#f8fafc), body text (#e2e8f0), links & accents (#38bdf8).bella-namespace,user@example.com,Keywordfilter).User Experience & Key Benefits
Testing & Verification
npm run test:type-check) — 0 errors found.http://localhost:9000).