fix(core): propagate filterQuery in GetInferenceServices and GetServeModels

[vjkumar2756]

Close #3207

Problem & Root Cause

Problem

When querying GET /inference_services?filterQuery=... or GET /serve_models?filterQuery=..., the backend silently ignores the filterQuery parameter and returns all records unfiltered without raising any validation error.

Root Cause

1. Omitted Field Forwarding: In internal/core/inference_service.go (GetInferenceServices) and internal/core/serve_model.go (GetServeModels), the Pagination struct initialization copied PageSize, OrderBy, SortOrder, and NextPageToken from api.ListOptions, but left out FilterQuery.
2. Missing Interface Implementation: The database filtering engine uses ApplyFilterQuery(), which requires list options to implement the FilterApplier interface. InferenceServiceListOptions in internal/db/models/inference_service.go was missing the GetRestEntityType() method, causing ApplyFilterQuery() to silently skip filtering.

---

What Changed?

1. internal/db/models/inference_service.go

Implemented FilterApplier on InferenceServiceListOptions:

// GetRestEntityType implements the FilterApplier interface.
func (i *InferenceServiceListOptions) GetRestEntityType() filter.RestEntityType {
    return filter.RestEntityInferenceService
}

[pboyd]

/ok-to-test

[pboyd]

Thanks for the fix, @vjkumar2756. It looks good.

This appears to be AI-generated, which is absolutely fine, but it needs a disclosure per Kubeflow's policy. If you can amend the commit with Assisted-by or Co-authored-by line and force push the branch, we can merge it. (And, if I'm wrong about it being AI-generated, just let me know).

[vjkumar2756]

Thanks for the review @pboyd
Just to clarify, I found the issue myself after seeing a similar problem in another project and checking whether it existed here. I used AI as a supporting tool for confirmation, debugging, and checking the implementation, but the issue identification and investigation were my own.

I have amended the commit to include the Assisted by : disclosure trailer and force pushed the branch.
Ready for merge! I am also happy to explain how I identified the issue and worked through the fix.
Thanks again for the feedback.

[pboyd]

Thanks, @vjkumar2756.

/ok-to-test
/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pboyd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [pboyd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment