-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Controller::owns_stream
#1173
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
+ Coverage 72.43% 72.58% +0.15%
==========================================
Files 65 67 +2
Lines 4759 5213 +454
==========================================
+ Hits 3447 3784 +337
- Misses 1312 1429 +117
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits, but looks good.
0410113
to
847d264
Compare
Signed-off-by: David Herberth <[email protected]>
Controller::owns_stream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
As shortly discussed on discord, this adds
owns_stream
andowns_stream_with
toController
to allowed customized watch streams for owned objects:This patch depends on #911 for docs and is an extension to #1163 .
This can be used to aid stream sharing (#1080).