Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SharedStore provider #1147

Closed
wants to merge 15 commits into from
Closed

SharedStore provider #1147

wants to merge 15 commits into from

Commits on Feb 17, 2023

  1. Added stream_subscribe which allows watch streams to have additional … 

    …event subscribers

Signed-off-by: Dan Spencer <[email protected]>
    @danrspencer
    danrspencer committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    8efdc15 View commit details
    Browse the repository at this point in the history

  2. StreamSubscribe now wraps items in arcs so that: 

    1. Remove expensive cloning of Kubernetes objects
2. Allow propogation of err events

Signed-off-by: Dan Spencer <[email protected]>
    @danrspencer
    danrspencer committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    8d77e0a View commit details
    Browse the repository at this point in the history

  3. Renamed watch_ext subscribable to subscribe 

    Co-authored-by: Eirik A <[email protected]>
Signed-off-by: Dan Spencer <[email protected]>
    @danrspencer @clux
    danrspencer and clux committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    934faec View commit details
    Browse the repository at this point in the history

  4. StreamSubscribe now allows subscribers how to handle lagging 

    Signed-off-by: Dan Spencer <[email protected]>
    @danrspencer
    danrspencer committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    a85fe3f View commit details
    Browse the repository at this point in the history

  5. Fixed clippy errors in StreamSubscribe 

    Signed-off-by: Dan Spencer <[email protected]>
    @danrspencer
    danrspencer committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    c3e6663 View commit details
    Browse the repository at this point in the history

  6. Fixed grammar in StreamSubscribe docs 

    Signed-off-by: Dan Spencer <[email protected]>
    @danrspencer
    danrspencer committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    0899436 View commit details
    Browse the repository at this point in the history

  7. Fixed rustfmt errors in StreamSubscribe 

    Signed-off-by: Dan Spencer <[email protected]>
    @danrspencer
    danrspencer committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    a57184a View commit details
    Browse the repository at this point in the history

  8. Improved the documentation for WatchStreamExt::stream_subscribe method. 

    Also renamed WatchStreamExt::subscribe to WatchStreamExt::stream_subscribe. The compiler was unable to tell if we were trying to call WatchStreamExt::subscribe or StreamSubscribe::subscribe when they were named the same.

e.g. this code would not compile:

let stream_subscribe = stream.subscribe();
let subscription = stream_subscribe.subscribe();

Signed-off-by: Dan Spencer <[email protected]>
    @danrspencer
    danrspencer committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    77b7db0 View commit details
    Browse the repository at this point in the history

  9. Put StreamSubscribe behind a feature flag unstable_runtime_subscribe 

    Signed-off-by: Dan Spencer <[email protected]>
    @danrspencer
    danrspencer committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    8b28a9b View commit details
    Browse the repository at this point in the history

  10. Update kube-runtime/src/utils/mod.rs 

    Co-authored-by: Eirik A <[email protected]>
Signed-off-by: Dan Spencer <[email protected]>
    @danrspencer @clux
    danrspencer and clux authored Feb 17, 2023
    Configuration menu
    Copy the full SHA
    efb4166 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Fixed rustfmt error in kube-runtime utils mod.rs 

    Signed-off-by: Dan Spencer <[email protected]>
    @danrspencer
    danrspencer committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    a320b19 View commit details
    Browse the repository at this point in the history

  2. Fixed incorrect feature flag usage for the unstable-runtime-subscribe… 

    … feature

Signed-off-by: Dan Spencer <[email protected]>
    @danrspencer
    danrspencer committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    e152543 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Created a SharedStore which can return the same instance of a store f… 

    …or the same list params for a given type. Also allows subscriptions to those stores.

Signed-off-by: Dan Spencer <[email protected]>
    @danrspencer
    danrspencer committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    3b67d6d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into shared_stores_2

    @danrspencer
    danrspencer authored Feb 21, 2023
    Configuration menu
    Copy the full SHA
    7c1cee1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into shared_stores_2

    @danrspencer
    danrspencer authored Feb 21, 2023
    Configuration menu
    Copy the full SHA
    4f0418c View commit details
    Browse the repository at this point in the history