Repository navigation
Conversation
LSchu
commented
Oct 5, 2026
|
|
||
| // FindGitRepoRoot traverses upwards from startDir looking for a .git directory or file | ||
| // (supporting standard repositories, worktrees, and git submodules). | ||
| // If no git repository root is found, it returns an empty string and an error. |
Contributor
Author
There was a problem hiding this comment.
TODO: Add error handling
LSchu
marked this pull request as draft
October 6, 2026 08:32
LSchu
changed the title
tuunit
reviewed
Oct 7, 2026
tuunit
left a comment
tuunit
left a comment
Contributor
There was a problem hiding this comment.
(!) BREAKING: remove --work-dir, --config-file and --env-file flags. This is done in order to make it impossible to run kubara commands with configuration which does not belong to the current hub.
I think that is a no go. We know of users who are using those flags explicitely. This would force the file names .env and config.yaml, right?
Even our CI would break I think
tuunit
requested changes
Oct 7, 2026
| |--------------|------------|-----------------|--------------------|--------------------| | ||
| | | | | | | | ||
|
|
||
| # Directory-Scoped Workspaces for Multi-Hub GitOps Repositories |
Contributor
There was a problem hiding this comment.
Whats a workspace in this context?
Maybe without introducing a "new" word and needing a definition what we mean in the context fo GitOps/kubara. Something simplified like:
Suggested change
| # Directory-Scoped Workspaces for Multi-Hub GitOps Repositories | |
| # Directory-Scoped Multi-Hub GitOps Repositories |
| ## Decision Drivers | ||
|
|
||
| - Different configurations may use different catalog versions and platform stacks. | ||
| - Templating for one configuration must never mutate, wipe, or overwrite another configuration's artifacts. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Templating for one configuration must never mutate, wipe, or overwrite another configuration's artifacts. | |
| - Templating for one configuration must never mutate, wipe or overwrite another configuration's manifests. |
|
|
||
| - Different configurations may use different catalog versions and platform stacks. | ||
| - Templating for one configuration must never mutate, wipe, or overwrite another configuration's artifacts. | ||
| - Zero breaking changes to existing single-configuration repositories. |
Contributor
There was a problem hiding this comment.
Which wouldn't be true if we remove --config-file and/or --env-file
| - Zero breaking changes to existing single-configuration repositories. | ||
| - Keep Terraform relative module paths (`../../../../platform-components/...`) working without requiring modifications to catalog templates. | ||
| - Git repository subpaths must be computed automatically to simplify Argo CD GitOps workflows. | ||
| - Developer experience must be intuitive: easily target individual setups or run batch generation across all setups. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Developer experience must be intuitive: easily target individual setups or run batch generation across all setups. | |
| - Developer experience must be intuitive: Easily target individual multi-hub directories or run batch generation across all. |
|
|
||
| ## Decision Outcome | ||
|
|
||
| Chosen option: **One Hub per Config, one Folder per Hub**. |
Contributor
There was a problem hiding this comment.
Suggested change
| Chosen option: **One Hub per Config, one Folder per Hub**. | |
| **One Hub per Config, one Folder per Hub**. |
| Because `platform-configs` and `platform-components` remain siblings inside each hub directory, existing Terraform relative source paths (`../../../../platform-components/...`) remain valid. | ||
|
|
||
| ### Automatic GitOps Path Computation | ||
| When executing within a hub folder, kubara generate automatically: |
Contributor
There was a problem hiding this comment.
Suggested change
| When executing within a hub folder, kubara generate automatically: | |
| When executing within a hub folder, `kubara generate` automatically: |
Comment on lines
+55
to
+57
| 1. **Directory Scoping**: Commands execute within the hub directory or target hubs via `--hub`. Legacy flags (`--work-dir`, `--config-file`, and `--env-file`) are removed in favor of directory-scoped context. | ||
| 1. **Batch Generation**: `kubara generate --all` (alias `-A`) discovers all configurations in the current directory and generates each hub in its own isolated context. | ||
| 1. **Removal of old Flags**: `--work-dir`, `--config-file` and `--env-file` have been removed and are replaced by `--hub` |
Contributor
There was a problem hiding this comment.
to be discussed and duplication
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve support for multi-hub setups
Change type
Breaking change
How I tested it
Notes for reviewers
solves #600
docs/content/10_decisions/ADR-0005-multi-hub-improvements.md WIP and subject to discussions and extensions, for example --hub support for more subcommands.
still need to do a bit of testing and verification for edge cases