-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add S390x support #138
Conversation
Signed-off-by: Modassar Rana <[email protected]>
Added s390x architecture as build operation is successful. Signed-off-by: Modassar Rana <[email protected]>
Removed echo Version ( was added for testing local) Signed-off-by: Modassar Rana <[email protected]>
Removed unwanted space Signed-off-by: Modassar Rana <[email protected]>
@spolti Please merge , as you have approved the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @modassarrana89, looks like GRPC added support for s390x a while ago. Please rebase this with main again when you can.
I have done that. Can you please merge the PR now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: modassarrana89, rafvasq, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Modifications
Added linux/s390x ( platform ) in the build github workflow
Result
https://github.com/modassarrana89/modelmesh/actions/runs/8688245342/job/23823937204 // Build operation run in local workflow is a success. Attached archieve log for refernece
logs_22763759557.zip