Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address bounce castle cve alert #122

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

spolti
Copy link
Contributor

@spolti spolti commented Nov 16, 2023

chore: Update bouncy castle depdendency to address the following vulnerability:

Motivation

Modifications

Result

chore: Update bouncy castle depdendency to address the following vulnerability:
- [CVE-2023-33201](https://nvd.nist.gov/vuln/detail/CVE-2023-33201): Bouncy Castle For Java LDAP injection vulnerability

Signed-off-by: Spolti <[email protected]>
@njhill
Copy link
Member

njhill commented Nov 16, 2023

@spolti we're on java 17, does bcpkix-jdk18on work ok with that?

@spolti
Copy link
Contributor Author

spolti commented Nov 16, 2023

Hi @njhill, 18on is for JDK 1.8 and later: https://www.bouncycastle.org/latest_releases.html

@njhill
Copy link
Member

njhill commented Nov 16, 2023

@spolti aah nice, I thought it might be 18 not 1.8 lol

Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhill, rafvasq, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rafvasq rafvasq merged commit 7419d21 into kserve:main Nov 20, 2023
7 checks passed
@spolti spolti deleted the bouncyCastle-c branch November 21, 2023 16:10
@ckadner ckadner added this to the v0.11.2 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants