fix: Avoid string concat and regex inefficiency (#117)

- Execute external commands using an array of strings
  rather than a single string
- Make the regular expression pattern a bit more efficient

---------

Signed-off-by: Rafael Vasquez <[email protected]>

src/main/java/com/ibm/watson/modelmesh/ModelMesh.java

@@ -927,7 +927,7 @@ protected final TProcessor initialize() throws Exception {
     // "type" or "type:p1=v1;p2=v2;...;pn=vn"
     private static final Pattern METRICS_CONFIG_PATT = Pattern.compile("([a-z;]+)(:\\w+=[^;]+(?:;\\w+=[^;]+)*)?");
     // "metric_name" or "metric:name;l1=v1,l2=v2,...,ln=vn,"
-    private static final Pattern CUSTOM_METRIC_CONFIG_PATT = Pattern.compile("([a-z_:]+);(\\w+=[^;]+(?:;\\w+=[^,]+)*)?");
+    private static final Pattern CUSTOM_METRIC_CONFIG_PATT = Pattern.compile("([a-z_:]+);(\\w+=[^;]+(?:;\\w+=[^,]++)*)?");
 
     private static Metrics setUpMetrics() throws Exception {
         if (System.getenv("MM_METRICS_STATSD_PORT") != null || System.getenv("MM_METRICS_PROMETHEUS_PORT") != null) {

src/test/java/com/ibm/watson/modelmesh/ModelMeshTearDownTest.java

@@ -315,7 +315,7 @@ public static int getPID(Process process) throws Exception {
     }
 
     public static int killProcess(Process process) throws Exception {
-        int pid = getPID(process);
-        return Runtime.getRuntime().exec("kill -9 " + pid).waitFor();
+        String pid = Integer.toString(getPID(process));
+        return Runtime.getRuntime().exec(new String[] {"kill", "-9", pid}).waitFor();
     }
 }