also send notify/progress across connection #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function resolveLocal(id, value) { | ||
| _debug('resolve:', "L" + JSON.stringify(id), JSON.stringify(value), typeof value); | ||
| locals.get(id).resolve(value); | ||
| function resolveLocal(id, op, value) { |
There was a problem hiding this comment.
Seems that we’re not getting much utility from this utility function. The resolve in resolveLocal certainly no longer applies. Perhaps we should inline this.
There was a problem hiding this comment.
There are currently 4 instance of use of this util function: line 56, 62, 191 and 261. I am for making it inline for line 56 and 62, but I have insufficient knowledge on other two instances. If you can suggest a solution, I will make the changes
There was a problem hiding this comment.
I’ll take care of it in a follow-up. They are all the same, really. The other cases are for encoding references to local promises in message arguments.
|
Looks good to me. |
|
@blai I am adding you to the project contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #19