Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creator result selection currently resets to the latest version in several workspaces, and artifact history has no shared provenance view. This adds a reusable “Artifact versions and sources” panel inside CreatorCollaborationPanel and persists historical project-result selection through the existing Command Dispatcher.
Validation performed:
Limits: artifacts without a result snapshot are browse/download-only. Text comparison supports up to 200,000 characters and displays 2,000 lines; it does not align inserted/deleted lines. Packaged Electron App, embedded Web hashes, full test suite and live Providers were not validated. This PR does not claim release readiness.
CI dependency fix: upgrade sharp to 0.35.4 in workspace and packaged runtime, override vulnerable ws 8.x to 8.21.0, and remove unused toml (configuration already uses @iarna/toml). npm registry audit now reports 0 high/critical vulnerabilities (24 low/moderate remain). Both frozen lockfiles, 25 targeted tests, Daemon typecheck and compilation passed locally. Packaged Electron was not revalidated.
CI test corrections: Dashboard's in-memory service now handles select-result-version and the history assertion waits for command completion (38 Dashboard tests and Web typecheck passed). Whisper parity now checks the actual host capabilities instead of assuming the Ubuntu runner is Windows; the full Windows save flow passed locally. The preceding CI run passed the full unit/integration suite, typechecks, builds and smoke; 10/11 browser parity tests passed before the host-specific assertion was corrected.
Final CI: https://github.com/krillinai/OpenCreator/actions/runs/34955220464 passed on 25103f7, including dependency audit, full tests, typechecks, builds, smoke, all Browser/Desktop Bridge parity checks and performance gates. Packaged Electron and embedded-resource hash verification remain outside this CI run.