Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dirty conversion to a flake #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dirty conversion to a flake #22

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Contributor

@Mic92 Mic92 commented Aug 15, 2020

No description provided.

@@ -1,3 +1,4 @@
{ nixpkgsLib }:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks existing usage in the overlay.
If you have better suggestion on how to solve this let me know.
I actually I would just get rid of the overlay because it is over-engineering and
makes direct import harder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overlay doesn't really use lib, so this addition should not matter too much. Could we have nixpkgsLib ? import <nixpkgs/lib> for non-flakes users?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just get rid of the overlay because it is over-engineering

We can probably get rid of it. I did a quick search and couldn't find any place where it gets used as overlay anyway.

inherit (self) lib;
};
in {
packages = (pkgs.callPackage ./pkgs/krops {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We flakes you can build stuff like:

$ nix run 'github:Mic92/dotfiles#deploy.eve`

https://github.com/Mic92/dotfiles/blob/master/flake.nix#L55
https://github.com/Mic92/dotfiles/blob/master/nixos/krops.nix#L18

@pinpox
Copy link

pinpox commented Jul 29, 2021

Any updates on this? Would be great to be able to use krops as a flake without needing a fork.

@4z3
Copy link
Contributor

4z3 commented Jul 29, 2021

Any updates on this?

There is no progress, yet. The main reason for that being that nobody maintaining this particular repository is using flakes at the moment. That said, we do eventually want to support flakes here, too.

Would be great to be able to use krops as a flake without needing a fork.

What's wrong with using forks? There's nothing special about this repository besides being a mirror of the first public krops repository. Using @Mic92's fork or even rolling your own is a perfectly valid thing to do. Once this issue gets closed (you will probably get notified as participant), you can freely switch back to this repository if you feel a need to do so.

NB we do eventually want converge all compatible forks, but doing so has no priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants