-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The stack tool can delete stacks now. #4
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Teh-Mad-Cow <[email protected]>
Signed-off-by: Teh-Mad-Cow <[email protected]>
Signed-off-by: Teh-Mad-Cow <[email protected]>
(A) Make the default right-click action delete stacks, and make the stack mode right-click action delete single particles from stacks. In this proposal, unmodified-right-click in stack mode could also be made to delete only one particle per mouse-down. This would be most consistent with stack mode's existing intuition, but would make default right click laggy and mess up existing users' workflow. I'm leaning more towards (B), but let me know what you think. |
I wasn't sure how to do that originally, but I think I got it. The exact implementation might vary, but is this reasonable? I could change how
Oops yeah I wasn't planning to continue work on it, till you mentioned how [Stack] mode treats clicks. I'm going to save that for last though, as it's still incredibly niche. I only wanna include it for completeness As for points 3 and 4, yeah I'll go ahead and do that. Option B is the least disruptive to regular workflow. Took me a bit to come around, but yeah it really does fit there better in the [Stack] mode. |
Your changes had inspired me to rework the toolset framework a bit, so hold on the changes related to making the stack tool toggleable for now. I think I might end up just going ahead and merging that manually. For (1), I would recommend abstracting those functions so that they return a vector of particles, and putting them in a separate file. The reason why I mentioned them is because its implementation of DrawLine is faster, and it's a good starting point if you're planning to port DrawFill. If this sounds complicated, it's fine if you just copy-paste your existing routines; I can do the refactor myself. |
The stack tool now switches to a toolset like the config tool, so that the secondary button deletes whole stacks. It supports brushes, lines, and boxes.
While it performs better than the stack tool when dragging, it could still use some improvement.