-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Create legacy audioscrobbler API #37
Conversation
maloja/apis/legacy_audioscrobber.py
Outdated
return 200, "OK\n" + | ||
sessionkey + "\n" + | ||
protocol + "://"+domain+":"+port+"/apis/legacyaudioscrobbler/nowplaying" + "\n" + | ||
protocol + "://"+domain+":"+port+"/apis/legacyaudioscrobbler/scrobble" + "\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure how to get the protocol, domain and port of requests from nimrodel, so I placed placeholder variables to show where they are supposed to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One idea I had is getting all this information through the otherwise redundant username, but a more elegant and hidden solution would be nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have time to test it now, but I added a line to get the host from the HTTP header, check if you can use that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo in filename legacy_audioscrobbler (letter "l" after "bb")
Since the use case for this protocol is gonna be very limited, I think it would be an acceptable option to just have the user specify their public url in the settings - but the |
Thanks - I'm having trouble getting it set up for testing since I don't currently have access to a Linux machine (maloja tries to find Linux environment variables that don't exist on windows) but I'll push my code as soon as i can |
Do not merge, work in progress. Will resolve #35