Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overriden required #1868

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Conversation

fft001
Copy link
Contributor

@fft001 fft001 commented Feb 27, 2024

This is an attempt to fix the issue described in #1802.

Without the reordering the generated pydanticv1/v2 models would lack imports such as Field and AwareDatetime.

Please let me know if this is a valid option.

Thanks.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@a4a3a42). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1868   +/-   ##
=======================================
  Coverage        ?   98.89%           
=======================================
  Files           ?       37           
  Lines           ?     4157           
  Branches        ?      968           
=======================================
  Hits            ?     4111           
  Misses          ?       29           
  Partials        ?       17           
Flag Coverage Δ
unittests 98.55% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 27, 2024

CodSpeed Performance Report

Merging #1868 will not alter performance

Comparing fft001:fix_overriden_required (82bdbca) with main (a4a3a42)

Summary

✅ 29 untouched benchmarks

@koxudaxi koxudaxi merged commit e1c795e into koxudaxi:main Mar 6, 2024
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants