Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Test Coverage and Add HasWilaya and HasCommune traits #32

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

n4ss1m
Copy link
Collaborator

@n4ss1m n4ss1m commented Mar 11, 2025

  • Refactor & Test Coverage:

    • Increased test coverage to 100%.
    • Replaced PHPUnit tests with PestPHP-based tests for better readability.
  • New Features:

    • Introduced HasWilaya and HasCommune traits to simplify model associations with Wilayas and Communes.
    • Updated documentation (README.md) to include usage examples for new traits.
  • Refactoring & Cleanup:

    • Moved Wilaya and Commune models into Models/ namespace.
    • Removed deprecated methods and improved type hinting.
    • Integrated spatie/laravel-package-tools for better package structure.

Breaking Changes

  • Models have been moved to Models/ namespace, which may require updates in consuming applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant