Skip to content

Conversation

@granis
Copy link

@granis granis commented Jul 4, 2022

Hey,

Great plugin! Very useful.
I made one addition, use/mod it if you are interested.

What is the problem?
For Bungeecord-servers, as noted in README, many worlds are mixed up due to same name.
However, the server-names in Bungeecord are unique.

What is the solution?
Prefix all world-names with the Bungeecord-server-name.

Example
Instead of "world", the name will be "server512_world". And it wont collide with "lobby_world" anymore.

Known bugs?
The first player joining will get "UNKNOWN_world" as mapname, but after a few seconds (at most) the bungeecord-server will reply with the server-name, and the worldname will be re-sent. So the name will be corrected. Possibly resulting in lots of new map entries in Xaero/client.

The server-name is saved after lookup, so only one player will have this problem ✨

@kosma
Copy link
Collaborator

kosma commented Jul 4, 2022

Thanks for the PR. I really feel this functionality should be handled on Bungeecord/Velocity... it would save a lot of trouble of having to install the mod on all the different backend servers, and would also avoid hacks related to waiting for the settings packet. I don't want to accept the PR in this form - but I am considering adding Bungeecord/Velocity support to the mod, to do what you suggested (prepending server name to the world name).

I'm currently on vacation - I will look at this in more detail once I'm back. :)

@granis
Copy link
Author

granis commented Jul 4, 2022

I agree it should be handled on the proxy, but I was under the impression that no such data (worldchange) is available on bungeecord?

Unless you use packet-rewriting, which I guess would be a very easy approach, but less update-safe.. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants