Lots of fixes and improvements #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rough summary: * added most/all that is required for deploying to maven central (through sonatype) * added lots of reporting plugins (use with `mvn site`)
* much more modular code * jUnit testing introduction there are tests that run and do something, but they do not yet actually check something useful, except for exceptions * test example images are now read as resources, so it should work more reliably
... for possible future modularization
We use the Java method, because it allows us to keep the files for inspection if we want to. Temporary files options: * Java: files are deleted on JVM exit (or optionally not deleted at all) * JUnit: files are deleted at end of test
* TiledImageMatrix ** now extends ImageMatrix ** uses dimensions instead of x&y / w&h * AsciiExporter ** init(source) -> init(targetDimensions)
Owner
|
Sick number of changes :) I'll try to make some time in the following days to review it all, thank you for your effort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.