Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/NifiConnection] Implementation of NifiConnection controller #168

Closed
wants to merge 62 commits into from
Closed

[Feature/NifiConnection] Implementation of NifiConnection controller #168

wants to merge 62 commits into from

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Sep 21, 2022 •
edited
Loading

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets #171
License Apache 2.0

What's in this PR?

New resource to create connection between component (e.g. NifiDataflow) and some tweeks to improve the code reuse.

Why?

To add new feature to NiFiKop.
To connect 2 dataflows together without manual action.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

juldrixx and others added 30 commits June 29, 2022 15:14
@juldrixx
Add NifiConnection resource skeleton
71b9ff7
@juldrixx
Comment line
fa45165
@juldrixx
Manage GetDataflowComponentInformation
c358332
@juldrixx
Add cluster verification
3aed6d6
@juldrixx
Add cluster connection
9ed7408
@juldrixx
Add connection configuration
a5aaef6
@juldrixx
Add finalizer, status management and start label management
2575348
@juldrixx
Add stop-component label management
954c387
@juldrixx
Update port stopping feature
b3b56d8
@juldrixx
Add function to check if connection exists
003b8b3
@juldrixx
Add annotations to store last nificluster applied
9858215
@juldrixx
-
45cca04
@juldrixx
Rebase on master
65dee6b
@juldrixx
Fix issues following rebase
06df7fc
@juldrixx
Add capability to identify if an input connection is active
f7451e0
@juldrixx
Add capability to update the connection configuration
ee079b0
@juldrixx
Add update connection destination
99b6750
@juldrixx
[WIP] Add update connection destination && update connection source
4669b88
@juldrixx
WIP update source and destination
5fd01cb
@juldrixx
Merge branch 'master' into feature/nificonnection_resource
2e71ad2
@juldrixx
Merge branch 'master' into feature/nificonnection_resource
1b36eff
@juldrixx
Upgrade nigoapi & Add labelIndex & Manage update source/destination i…
1f90a39 
…n the same nificluster and configuration
@juldrixx
Remove old code and fix state
820bd44
@juldrixx
Add drop queue flowfiles if drop strategy on connection and dataflow
a6616e9
@juldrixx
Unify kubebuilder validation
703587b
@juldrixx
Fix DropRequest management
4c2f384
@juldrixx
Add finilizer deleting
b87082f
@juldrixx
Save clusterRef after creation
8eb7834
@juldrixx
Unify finalizer label management
d04ae35
@juldrixx
Manage clusterRef changment connection & Modify all update to patch i…
e2eff09 
…n nifidataflow
@konpyutaika konpyutaika deleted a comment from gitguardian bot Oct 2, 2022
@juldrixx
Copy link
Contributor Author

juldrixx commented Oct 2, 2022

It would be interesting to add documentation on how to use this feature with concrete examples.

What do you mean? I did add some documentation on this subject.

@konpyutaika konpyutaika deleted a comment from gitguardian bot Oct 3, 2022
@juldrixx juldrixx requested review from erdrix and removed request for mh013370 October 14, 2022 10:21
@konpyutaika konpyutaika deleted a comment from gitguardian bot Oct 16, 2022
@konpyutaika konpyutaika deleted a comment from gitguardian bot Oct 27, 2022
@konpyutaika konpyutaika deleted a comment from gitguardian bot Apr 25, 2023
@konpyutaika konpyutaika deleted a comment from gitguardian bot Aug 28, 2023
@konpyutaika konpyutaika deleted a comment from gitguardian bot Aug 28, 2023
@konpyutaika konpyutaika deleted a comment from gitguardian bot Aug 28, 2023
@juldrixx juldrixx mentioned this pull request Aug 28, 2023
Merged
5 tasks
@juldrixx juldrixx closed this Aug 28, 2023
@juldrixx juldrixx deleted the feature/nificonnection_resource branch August 28, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mh013370 mh013370 mh013370 left review comments

@erdrix erdrix Awaiting requested review from erdrix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NiFi connection
3 participants
@juldrixx @mh013370 @erdrix