feat(RELEASE-1244): make create-github-release task idempotent #666
+106
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
jinqi7
force-pushed
the
RELEASE-1244
branch
3 times, most recently
from
d545764
to
7249e6c
Compare
johnbieren
reviewed
Nov 7, 2024
There was a problem hiding this comment.
@ernesgonzalez33 the code here LGTM, but can you also give it a quick look as you were involved in the creation of the release to github pipeline?
tasks/create-github-release/tests/test-create-github-exist-release.yaml
Outdated
Show resolved
Hide resolved
tasks/create-github-release/tests/test-create-github-exist-release.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Jing Qi <[email protected]>
|
LGTM but I'd like to wait for Ernesto to give it a look before we merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.