Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail cleanup if internalrequests not installed #626

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Don't fail cleanup if internalrequests not installed #626

merged 1 commit into from
Nov 8, 2024

Conversation

ralphbean
Copy link
Member

This is the case on the new Fedora Cluster run by the Konflux+Fedora SIG

@ralphbean ralphbean requested a review from a team as a code owner October 18, 2024 20:27
@ralphbean
Copy link
Member Author

This should help fix konflux-ci/release-service#589

@ralphbean ralphbean force-pushed the gentle-with-internalrequests branch 2 times, most recently from 8bbedf0 to d9f2538 Compare October 18, 2024 20:34
@openshift-ci openshift-ci bot added the lgtm label Oct 21, 2024
@ralphbean
Copy link
Member Author

/retest

@redhat-appstudio-qe-bot
Copy link

❗ Detected an outage of the following critical component(s)❗

  • quay: Build System

Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages:

and add a comment /retest-required once the reported issues are solved

@ralphbean
Copy link
Member Author

/retest

1 similar comment
@happybhati
Copy link
Contributor

/retest

@happybhati
Copy link
Contributor

It needs a quick rebase from development!
Code LGTM!

@johnbieren
Copy link
Collaborator

@ralphbean can you rebase this so we can merge it?

@openshift-ci openshift-ci bot removed the lgtm label Oct 31, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 31, 2024

New changes are detected. LGTM label has been removed.

@johnbieren
Copy link
Collaborator

/retest

@johnbieren johnbieren enabled auto-merge (squash) October 31, 2024 15:10
@johnbieren
Copy link
Collaborator

/retest

8 similar comments
@johnbieren
Copy link
Collaborator

/retest

@ralphbean
Copy link
Member Author

/retest

@johnbieren
Copy link
Collaborator

/retest

@johnbieren
Copy link
Collaborator

/retest

@happybhati
Copy link
Contributor

/retest

@johnbieren
Copy link
Collaborator

/retest

@johnbieren
Copy link
Collaborator

/retest

@jinqi7
Copy link
Collaborator

jinqi7 commented Nov 1, 2024

/retest

@johnbieren
Copy link
Collaborator

E2E is broken. We have been discussing it on our team channel. I don't know how the e2e breaking prs passed e2e and got merged, but that is the state we are in

@jinqi7
Copy link
Collaborator

jinqi7 commented Nov 4, 2024

/retest

@johnbieren johnbieren force-pushed the gentle-with-internalrequests branch 2 times, most recently from 945ca25 to c2488a1 Compare November 8, 2024 01:25
@johnbieren johnbieren enabled auto-merge (squash) November 8, 2024 01:25
@johnbieren
Copy link
Collaborator

/retest

@ralphbean @johnbieren
fix: don't fail cleanup if internalrequests not installed
5cde5cf 
This is the case on the new Fedora Cluster run by the Konflux+Fedora SIG

Signed-off-by: Ralph Bean <[email protected]>
@konflux-ci-qe-bot
Copy link

@ralphbean: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
konflux-e2e-tests-catalog-qpjb6 Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:konflux-e2e-tests-catalog-qpjb6

@johnbieren
Copy link
Collaborator

Only the rh-push-to-registry-redhat-io test failed and it failed on the run-file-updates task, which isn't related to this change. Merging

@johnbieren johnbieren merged commit cd59faf into development Nov 8, 2024
6 of 7 checks passed
@johnbieren johnbieren deleted the gentle-with-internalrequests branch November 8, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbieren johnbieren johnbieren approved these changes

@mmalina mmalina mmalina approved these changes

Assignees

@mmalina mmalina

@johnbieren johnbieren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ralphbean @redhat-appstudio-qe-bot @happybhati @johnbieren @jinqi7 @konflux-ci-qe-bot @mmalina