Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for how to test with testing farm #134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ralphbean
Copy link
Member

Notably, this adds a third-parties section to the integration testing doc section. I expect we will expand this more over time, with jenkins, prow, and others.

This is a port of redhat-appstudio/docs.appstudio.io#230 to the new repo.

Copy link

🚀 Preview is available at https://pr-134--konflux-docs.netlify.app

Notably, this adds a `third-parties` section to the integration testing
doc section. I expect we will expand this more over time, with jenkins,
prow, and others.
Copy link

🚀 Preview is available at https://pr-134--konflux-docs.netlify.app

@ralphbean
Copy link
Member Author

@lukaszachy I finally copied over the old guide from redhat-appstudio/docs.appstudio.io#230 here, and cleaned it up a little.

IIRC, you've done more with testing farm recently, and maybe have a better way to do things that we should be sharing with other users here.

Do you have any advice you can give here? Links?

Comment on lines +28 to +29
**** Third Parties
***** xref:how-tos/testing/integration/third-parties/testing-farm.adoc[Testing with Testing Farm]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you anticipate having many more of these? I think that this is the first indentation of this length and if feels like it might be too much, especially since there is no content for "Third Parties."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do anticipate more - how to trigger jenkins, how to trigger prow, etc.

@@ -1,4 +1,4 @@
= Creating secrets for your builds
= Creating secrets for your pipelines
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't disagree with the accuracy of this change, but I think it muddies the intention. This is in the section "Configuring your builds" along with all the rest of the build pipeline configurations. Should we move this section out?

I think that these secrets are called build-time secrets in the UI, but that was to differentiate between the secrets that we used to have to deployments.


.Prerequisites

. You have xref:/how-tos/creating.adoc[created an application] in {ProductName}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users would need to create an application and a component?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True!


. Under **Key/value secret**, expand **Key/value 1**, then enter the key name `testing-farm-token`.

NOTE: Be sure that the secret name is `testing-farm-secret` and the key name is `testing-farm-token`. The link:https://github.com/ralphbean/testing-farm-tekton/blob/main/tasks/testing-farm.yaml[tekton task] expects the secret and key name to be named these strings exactly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to move this elsewhere other than in your repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do, but I want to see if @lukaszachy has better resources I should be directing readers to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants