-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructions for how to test with testing farm #134
base: main
Are you sure you want to change the base?
Conversation
47396c9
to
f43578d
Compare
f43578d
to
474e843
Compare
🚀 Preview is available at https://pr-134--konflux-docs.netlify.app |
Notably, this adds a `third-parties` section to the integration testing doc section. I expect we will expand this more over time, with jenkins, prow, and others.
474e843
to
6e85694
Compare
🚀 Preview is available at https://pr-134--konflux-docs.netlify.app |
@lukaszachy I finally copied over the old guide from redhat-appstudio/docs.appstudio.io#230 here, and cleaned it up a little. IIRC, you've done more with testing farm recently, and maybe have a better way to do things that we should be sharing with other users here. Do you have any advice you can give here? Links? |
**** Third Parties | ||
***** xref:how-tos/testing/integration/third-parties/testing-farm.adoc[Testing with Testing Farm] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you anticipate having many more of these? I think that this is the first indentation of this length and if feels like it might be too much, especially since there is no content for "Third Parties."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do anticipate more - how to trigger jenkins, how to trigger prow, etc.
@@ -1,4 +1,4 @@ | |||
= Creating secrets for your builds | |||
= Creating secrets for your pipelines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't disagree with the accuracy of this change, but I think it muddies the intention. This is in the section "Configuring your builds" along with all the rest of the build pipeline configurations. Should we move this section out?
I think that these secrets are called build-time secrets in the UI, but that was to differentiate between the secrets that we used to have to deployments.
|
||
.Prerequisites | ||
|
||
. You have xref:/how-tos/creating.adoc[created an application] in {ProductName} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users would need to create an application and a component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True!
|
||
. Under **Key/value secret**, expand **Key/value 1**, then enter the key name `testing-farm-token`. | ||
|
||
NOTE: Be sure that the secret name is `testing-farm-secret` and the key name is `testing-farm-token`. The link:https://github.com/ralphbean/testing-farm-tekton/blob/main/tasks/testing-farm.yaml[tekton task] expects the secret and key name to be named these strings exactly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to move this elsewhere other than in your repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do, but I want to see if @lukaszachy has better resources I should be directing readers to.
Notably, this adds a
third-parties
section to the integration testing doc section. I expect we will expand this more over time, with jenkins, prow, and others.This is a port of redhat-appstudio/docs.appstudio.io#230 to the new repo.