fix: resolve layout leak and duplicate feature card (#395) - #463
Conversation
|
Someone is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @komalharshita, I hope you are doing well! Just wanted to leave a gentle reminder regarding this PR. I have implemented the requested changes/features and ensured that all CI/CD pipeline checks are passing perfectly. Whenever you get some time, could you please review and merge it? Looking forward to your feedback. Thank you! |
|
@komalharshita please review this pull request |
komalharshita
left a comment
There was a problem hiding this comment.
Thank you for the contribution.
After reviewing this PR, I am unable to approve it in its current state.
The linked issue is focused on resolving a layout leak and duplicate feature card, but this PR introduces extensive changes to the recommendation form structure, submit button layout, error message markup, and other unrelated sections of index.html.
Additionally, the PR introduces duplicate DOM elements and duplicate IDs, including multiple instances of form-error-general and submit button related elements. Duplicate IDs can lead to invalid HTML and unpredictable JavaScript behavior.
The PR also currently contains merge conflicts and is not merge-ready.
Please keep the changes focused strictly on the layout leak / duplicate feature card issue, remove the duplicated UI elements, resolve merge conflicts, and resubmit for review.
Requested changes.
@komalharshita Thank you for the detailed feedback and for pointing out these issues. I apologize for the unintended changes and the duplicate IDs. I am currently working on fixing this. I will push the updated code shortly for your review. Thanks again for your guidance! |
|
@shivani11jadhav yeah np, ping me when youre done |
|
Hi @komalharshita, I have resolved all the merge conflicts directly on GitHub and completely cleaned up the branch.
The PR is now perfectly clean and ready for your final review. Could you please check and merge it? Thank you! |
|
@komalharshita please review PR if any changes needed please tell me |
Description
Addresses issue #395. The duplicate "Starter Code Included" card on the homepage was caused by an unclosed
divtag inside the "Area of Interest" form group section. This broke the DOM structure and leaked the layout into the features grid.Changes Made
<div class="form-group">container for the Area of Interest drop-down.Closes
Closes #395