Skip to content

fix: resolve layout leak and duplicate feature card (#395) - #463

Merged
komalharshita merged 4 commits into
komalharshita:mainfrom
shivani11jadhav:fix/duplicate-feature-card-39
Jun 8, 2026
Merged

fix: resolve layout leak and duplicate feature card (#395)#463
komalharshita merged 4 commits into
komalharshita:mainfrom
shivani11jadhav:fix/duplicate-feature-card-39

Conversation

@shivani11jadhav

Copy link
Copy Markdown
Contributor

Description

Addresses issue #395. The duplicate "Starter Code Included" card on the homepage was caused by an unclosed div tag inside the "Area of Interest" form group section. This broke the DOM structure and leaked the layout into the features grid.

Changes Made

  • Properly structured and closed the <div class="form-group"> container for the Area of Interest drop-down.
  • Verified that the features grid now displays correctly with a single "Starter Code Included" card.

Closes

Closes #395

@vercel

vercel Bot commented May 22, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first pull request to DevPath.

Before review:

  • Complete the PR template fully
  • Ensure all tests pass
  • Link your PR to an issue
  • Keep changes scoped to the issue

A maintainer will review your contribution soon.

@shivani11jadhav

shivani11jadhav commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

Hi @komalharshita,

I hope you are doing well! Just wanted to leave a gentle reminder regarding this PR. I have implemented the requested changes/features and ensured that all CI/CD pipeline checks are passing perfectly.

Whenever you get some time, could you please review and merge it? Looking forward to your feedback. Thank you!

@shivani11jadhav

Copy link
Copy Markdown
Contributor Author

@komalharshita please review this pull request

@komalharshita komalharshita left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.

After reviewing this PR, I am unable to approve it in its current state.

The linked issue is focused on resolving a layout leak and duplicate feature card, but this PR introduces extensive changes to the recommendation form structure, submit button layout, error message markup, and other unrelated sections of index.html.

Additionally, the PR introduces duplicate DOM elements and duplicate IDs, including multiple instances of form-error-general and submit button related elements. Duplicate IDs can lead to invalid HTML and unpredictable JavaScript behavior.

The PR also currently contains merge conflicts and is not merge-ready.

Please keep the changes focused strictly on the layout leak / duplicate feature card issue, remove the duplicated UI elements, resolve merge conflicts, and resubmit for review.

Requested changes.

@shivani11jadhav

shivani11jadhav commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for the contribution.

After reviewing this PR, I am unable to approve it in its current state.

The linked issue is focused on resolving a layout leak and duplicate feature card, but this PR introduces extensive changes to the recommendation form structure, submit button layout, error message markup, and other unrelated sections of index.html.

Additionally, the PR introduces duplicate DOM elements and duplicate IDs, including multiple instances of form-error-general and submit button related elements. Duplicate IDs can lead to invalid HTML and unpredictable JavaScript behavior.

The PR also currently contains merge conflicts and is not merge-ready.

Please keep the changes focused strictly on the layout leak / duplicate feature card issue, remove the duplicated UI elements, resolve merge conflicts, and resubmit for review.

Requested changes.

@komalharshita Thank you for the detailed feedback and for pointing out these issues. I apologize for the unintended changes and the duplicate IDs.

I am currently working on fixing this.

I will push the updated code shortly for your review. Thanks again for your guidance!

@komalharshita

Copy link
Copy Markdown
Owner

@shivani11jadhav yeah np, ping me when youre done

@shivani11jadhav

Copy link
Copy Markdown
Contributor Author

Hi @komalharshita,

I have resolved all the merge conflicts directly on GitHub and completely cleaned up the branch.

  1. Removed all duplicate blocks, duplicate 'submit-btn', and 'form-error-general' IDs in templates/index.html to keep it unique.
  2. Kept the new features like the scroll-to-top button intact while sorting out the script duplicates.
  3. Cleaned out all accidental backend files, leaving only the precise template fixes.

The PR is now perfectly clean and ready for your final review. Could you please check and merge it? Thank you!

@shivani11jadhav

Copy link
Copy Markdown
Contributor Author

@komalharshita please review PR if any changes needed please tell me

@shivani11jadhav

Copy link
Copy Markdown
Contributor Author

@komalharshita

@komalharshita komalharshita added gssoc:approved and removed need review Further information is requested labels Jun 8, 2026
@komalharshita
komalharshita merged commit 32bf7d5 into komalharshita:main Jun 8, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Duplicate "Starter Code Included" Feature Card on Homepage

2 participants