fix: improve responsive skill strip marquee behavior - #424
Closed
185xak wants to merge 2 commits into
Closed
Conversation
|
@185xak is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi @komalharshita , Just a gentle follow-up on this PR. The responsive overflow issue and marquee behavior improvements have been implemented, tested, and aligned with the issue requirements. Kindly review it whenever possible. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary [required]
This PR fixes the responsive overflow issue in the skills strip section where some skill tags extended beyond the container boundary on smaller screen sizes. It also completes the intended marquee animation behavior by implementing smooth automatic scrolling with hover pause interaction. Additionally, hover shadow clipping was resolved to improve the overall UI responsiveness and user experience.
Related Issue [required]
Closes #392
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
static/style.cssHow to Test This PR [required]
Checkout this branch:
git checkout fix/skills-tags-overflow
Install dependencies:
pip install -r requirements.txt
Run the application:
python app.py
Open:
http://127.0.0.1:5000
Navigate to the skills strip section on the homepage.
Resize the browser window to smaller screen widths and verify:
Run tests:
python tests/test_basic.py
Test Results [required]
PASS test_projects_json_loads
PASS test_each_project_has_required_fields
PASS test_find_project_by_id_found
PASS test_find_project_by_id_missing
PASS test_parse_skills_basic
PASS test_parse_skills_empty_string
PASS test_parse_skills_single_entry
PASS test_score_single_project_full_match
PASS test_score_single_project_no_match
PASS test_get_recommendations_returns_results
PASS test_get_recommendations_max_three
PASS test_get_recommendations_no_match_returns_empty
PASS test_get_recommendations_result_format
PASS test_validate_all_valid
PASS test_validate_missing_skills
PASS test_validate_missing_level
PASS test_validate_missing_interest
PASS test_validate_missing_time
PASS test_validate_all_missing
PASS test_home_route
PASS test_recommend_api_valid
PASS test_recommend_api_missing_field
PASS test_recommend_api_empty_body
PASS test_project_detail_found
PASS test_project_detail_not_found
PASS test_internal_server_error_page
PASS test_view_code_found
PASS test_download_code_found
PASS test_health_check
PASS test_scoring_weights_has_all_keys
30 passed, 0 failed out of 30 tests
Screenshots (if UI change)
|
|
|
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
The skills strip section now includes smooth automatic marquee scrolling behavior with hover pause interaction in addition to the responsive overflow fix.