Feat add skill shortlisting - #385
Closed
PraneshJha1038 wants to merge 4 commits into
Closed
Conversation
The file acts as a counter for all skill in skills.js
Introduces functions for getting, incrementing, loading, and saving skill counters
…, and status respectively
Additional Note: Removed skill toggle functionality as individual logic, and added it in renderDynamicTopSkills()
|
@PraneshJha1038 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@komalharshita Have a look |
Owner
|
closing the related PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary [required]
Implement dynamic top 5 skill selection buttons with server-side persistence to improve mobile UX and show community-driven trending skills.
Previously, the quick-select skill chips displayed a hard-coded list of 15 skills that stacked vertically on mobile screens, degrading the user experience. This PR replaces the hard-coded list with a dynamic top 5 system that:
data/skills_counters.jsonRelated Issue [required]
Closes #239
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
data/skills_counters.jsonutils/data_loader.pyload_skill_counters(),save_skill_counters(),increment_skill_counter(), andget_top_skills()functions with thread-safe file locking for concurrent accessroutes/main_routes.pyGET /api/top-skillsendpoint to fetch top 5 community skills andPOST /api/track-skillendpoint to increment skill countersstatic/script.jsincrementSkillCounter()andgetTopSkills()functions; addedtrackSkillOnServer(),loadTopSkillsFromServer(), and updatedrenderDynamicTopSkills()to fetch from serverHow to Test This PR [required]
git checkout feat/dynamic-top-5-skillspip install -r requirements.txtpython app.py/api/track-skillPOST requests in browser DevTools Network tabdata/skills_counters.jsonby inspecting the filedata/skills_counters.jsonExpected test output:
Test Results [required]
Screenshots (if UI change)
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
THIS PR MUST BE MERGED AFTER MERGING THE PR #259
Future Improvements (out of scope):