Add advanced projects and fix starter code downloads - #281
Conversation
uniunixunixunixxunixunix#
|
@jaygaikar-09 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@jaygaikar-09 kindly resolve the merge conflicts |
|
@komalharshita Done! |
komalharshita
left a comment
There was a problem hiding this comment.
Thanks for the contribution.
This PR contains some valuable improvements, particularly the nested starter-code path resolution, download handling fixes, additional tests, and documentation updates.
However, before merge there are several concerns that should be addressed.
Main issues:
• The PR combines two separate objectives:
- fixing starter-code download/path handling
- adding multiple new Advanced projects and starter templates
This significantly increases review scope and makes validation harder. Please consider separating bug-fix work from large catalog/content additions where possible.
• The new starter projects contain educational implementations that rely on in-memory storage and development-oriented defaults. Please clearly document these limitations so contributors and learners do not mistake them for production-ready patterns.
• Since the primary logic change is path resolution and security validation, additional tests should be added for:
- path traversal attempts (../)
- invalid nested paths
- malformed starter_code values
- absolute-path rejection
• Please perform a final consistency review of the newly added project metadata, roadmap structure, and resource links.
Once these concerns are addressed, the PR can be reviewed again.
|
Closing this PR for inactivity. Please open a fresh PR if possible. |
Summary [required]
This PR adds two new Advanced-level projects to the DevPath learning catalog and fixes starter-code serving for nested paths. The new projects include fully runnable starter templates for a real-time chat application and a JWT authentication REST API. In addition, starter file download/view logic was improved to correctly resolve nested directories safely, and new tests/documentation were added to cover the updated behavior.
Related Issue [required]
Closes #92
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
data/projects.jsonstarter_code/realtime_chat/app.pystarter_code/realtime_chat/templates/chat.htmlstarter_code/realtime_chat/requirements.txtstarter_code/jwt_auth_api.pystarter_code/jwt_requirements.txtutils/file_server.pyroutes/main_routes.pytests/test_basic.pySECURITY.mddocs/architecture.mdHow to Test This PR [required]