feat: Add <noscript> fallback message for users with JavaScript disabled - #276
Conversation
|
@Harshada-Yele is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @komalharshita Note: test_health_check has a pre-existing fixture bug unrelated to this PR. |
|
@Harshada-Yele sync your branch with the latest main and ensure all checks pass |
c3bb8aa to
da6a7bc
Compare
|
Hi @komalharshita |
komalharshita
left a comment
There was a problem hiding this comment.
Good contribution overall. The <noscript> fallback is a useful accessibility and progressive-enhancement improvement, and the implementation is clean and properly scoped.
The warning message is clear, the styling is lightweight and maintainable, and the navbar offset handling was thoughtfully considered. This improves the experience for users browsing with JavaScript disabled or restricted environments.
Minor future enhancement suggestion: consider adding an accessibility role such as role="alert" and slightly refining the wording depending on which site features actually require JavaScript.
Approved for merge.
|
@komalharshita |
Summary
This PR adds a
<noscript>fallback message totemplates/index.htmlso thatusers with JavaScript disabled see a clear explanation instead of a silently
broken form.
The warning banner is styled in
static/style.cssusing existingCSS custom properties and appears directly below the navbar. Without this change, the skill chip input system renders but is completely non-functional for
JS-disabled users with no feedback shown.
Related Issue [required]
Closes #256
Type of Change
data/projects.jsonWhat Was Changed
templates/index.html<noscript>block below<nav>to display fallback message when JS is disabledstatic/style.css.noscript-warningclass styled with warning colours andmargin-top: 64pxto account for fixed navbar heightHow to Test This PR
git checkout feat/noscript-fallbackpip install -r requirements.txtpython app.pychrome://settings/content/javascript127.0.0.1:5000http://127.0.0.1:5000— you should see a yellow warning banner below the navbar127.0.0.1:5000from the blocked list and reload — banner should disappearpytest tests/test_basic.py -k "not test_health_check"Expected test output:
Test Results
Screenshots
Self-Review Checklist
fix/noscript-fallbackpytest tests/test_basic.pyand 30 tests passprint()orconsole.log()debug statementsNotes for Reviewer
The
<noscript>tag is placed between the<nav>and<section class="hero">so it appears at the top of the page content. The
margin-top: 64pxin CSSaccounts for the fixed navbar height to prevent the banner being hidden behind it.