Skip to content

Improved dark mode UI consistency across the application. - #248

Closed
SRSoham wants to merge 5 commits into
komalharshita:mainfrom
SRSoham:main
Closed

Improved dark mode UI consistency across the application.#248
SRSoham wants to merge 5 commits into
komalharshita:mainfrom
SRSoham:main

Conversation

@SRSoham

@SRSoham SRSoham commented May 17, 2026

Copy link
Copy Markdown
Contributor

Changes Made

  • Fixed dark mode color inconsistencies
  • Improved UI appearance in dark mode
  • Updated theme styling

Related Issue

Closes #248

@vercel

vercel Bot commented May 17, 2026

Copy link
Copy Markdown

@SRSoham is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first pull request to DevPath.

Before review:

  • Complete the PR template fully
  • Ensure all tests pass
  • Link your PR to an issue
  • Keep changes scoped to the issue

A maintainer will review your contribution soon.

@SRSoham

SRSoham commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

Hi @komalharshita ,
Just following up on this PR whenever you get time to review. I’ve tested the dark mode changes locally and addressed the UI consistency issues across the pages.

Thank you!

@komalharshita

Copy link
Copy Markdown
Owner

@SRSoham you will have to resolve the merge conflicts before merging

However, before this PR can be approved, please update the PR description using the repository’s required PR template and properly link the related issue (for example using Closes #issue_number).

Maintaining consistent PR formatting and issue linkage is important for project tracking, review clarity, and GSSoC contribution validation.

Please make those updates and request re-review afterward.

@SRSoham SRSoham changed the title feat: improve dark mode UI consistency Improved dark mode UI consistency across the application. May 19, 2026
@SRSoham

SRSoham commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@komalharshita Merge conflicts resolved and PR description updated with the required template and linked issue. Ready for re-review.

@komalharshita

Copy link
Copy Markdown
Owner

@SRSoham merge conflicts still exist

@SRSoham

SRSoham commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@komalharshita merge conflicts have been resolved and changes pushed. Ready for re-review.

@komalharshita komalharshita left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the substantial contribution. The dark mode feature is valuable and it’s clear a significant amount of effort went into improving consistency across many sections of the application.

The theme toggle persistence logic is implemented well, and the PR meaningfully improves the overall user experience.

However, before this can be approved, there are several maintainability and architecture concerns that should be addressed:

  • The implementation relies heavily on !important across a very large number of selectors. This makes long-term maintenance and future styling changes difficult.

  • The PR introduces a massive monolithic dark-mode override block instead of using a cleaner theme-variable/token-based structure.

  • Because many unrelated components are modified simultaneously, there is elevated regression risk for hover states, responsiveness, spacing, and contrast consistency.

  • Please provide clearer testing evidence/screenshots for:

    • all major sections in dark mode
    • mobile responsiveness
    • forms/cards/buttons
    • accessibility contrast validation

Recommended improvements:

  • reduce unnecessary !important usage
  • consolidate repeated colors into reusable CSS variables
  • group dark mode styles by component/section for readability
  • clean up duplicate/redundant selectors where possible

This is a strong foundation, but it needs refactoring and cleanup before it is merge-ready.

@SRSoham

SRSoham commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for the detailed review and feedback.

I understand the maintainability concerns regarding the extensive use of !important, large override blocks, and styling organization.

I’ll work on:

  • reducing unnecessary !important usage
  • introducing reusable CSS variables/theme tokens
  • grouping dark mode styles component-wise
  • cleaning redundant selectors
  • validating responsiveness and accessibility contrast
  • adding proper screenshots/testing evidence

I appreciate the guidance and will push the refactored changes soon.

@SRSoham SRSoham closed this by deleting the head repository May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants