Added dark mode feature #206 - #207
Conversation
|
@Shashankpanchwatkar is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Shashankpanchwatkar kindly resolve the merge conflicts |
komalharshita
left a comment
There was a problem hiding this comment.
Thanks for working on a global dark mode system for DevPath — this is a valuable feature and the overall direction is good. However, after a detailed review, there are several important issues that need to be addressed before this can be merged.
Blocking issues
- The PR introduces duplicate skills-input elements with the same ID, which can break DOM behavior and accessibility.
- Existing accessibility attributes (aria-haspopup, aria-expanded, aria-controls) were removed from the original input.
- The dark mode JS assumes #theme-toggle exists on all pages and can throw runtime errors if the element is missing.
Additional concerns
innerHTML is being used where textContent would be safer and cleaner.
The toggle button is missing accessibility state attributes like aria-label and aria-pressed.
The PR contains a large amount of unrelated formatting/whitespace changes, which increases review difficulty and merge conflict risk.
Dark mode currently does not respect prefers-color-scheme.
This feature should be manually tested across desktop/mobile views and all major UI sections before merge.
Please address the above issues and update the PR with cleaned, scoped changes and verified UI testing.
|
closing this PR for inactivity |
Summary
Added a dark mode feature with a theme toggle button in the navbar. Implemented persistent theme switching using localStorage and updated multiple sections of the website to support a consistent dark UI experience.
Related Issue
Closes #108
Type of Change
What Was Changed
templates/index.htmlstatic/style.cssstatic/script.jsHow to Test This PR
Clone this branch:
git checkout dark-mode-featureInstall dependencies:
pip install -r requirements.txtRun the app:
python app.pyOpen:
http://127.0.0.1:5000Click the Dark/Light toggle button in the navbar.
Verify:
Test Results
Application tested successfully in browser. Dark mode toggle working correctly. Theme persistence verified using localStorage.