fix: allow GitHub avatar hosts in CSP img-src (issue #1875) - #1909
Merged
komalharshita merged 1 commit intoAug 16, 2026
Merged
Conversation
|
@ionfwsrijan is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
type:testing
gssoc-2026
type:bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for part in csp.split(";") | ||
| if part.strip().startswith("img-src ") | ||
| ) | ||
| assert "https://avatars.githubusercontent.com" in img_src |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GitHub avatar images on the profile page were blocked by the site's Content-Security-Policy. The CSP set
img-src 'self' data:, butprofile.htmlrenders{{ user.avatar_url }}, which ishttps://avatars.githubusercontent.com/...for GitHub-authenticated users, so the avatar never loaded.Fix
Added the GitHub avatar hosts to
img-srcin the CSP header (src/app.py):The
https://*.githubusercontent.comwildcard also covers related avatar/CDN subdomains used by GitHub-hosted content.Files changed
src/app.py— whitelist GitHub avatar hosts inimg-src.tests/test_basic.py— newtest_csp_allows_github_avatarsasserting the CSPimg-srcdirective includes both GitHub avatar hosts alongside'self'anddata:.Testing
img-srcdirective contains'self',data:,https://avatars.githubusercontent.com, andhttps://*.githubusercontent.com.py_compilepasses onsrc/app.py.Closes #1875