fix: apply technology stack filter in recommendations (issue #1870) - #1900
Merged
komalharshita merged 1 commit intoAug 16, 2026
Merged
Conversation
|
@ionfwsrijan is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Technology Stack dropdown on the recommendation page has no effect: the same recommendations are returned regardless of the selected stack.
project_matches_techis defined insrc/utils/recommender.pybut is never called, so the filter added in #936 and previously working via #1285 was silently dropped when the recommender engine was restored.Fix
Apply
project_matches_techinsideget_recommendations: when a non-alltech_stackis selected, filter the loaded projects before scoring, mirroring the original #936 implementation. Projects that do not match the selected stack are excluded from scoring, relevance, and final recommendations.Files changed
src/utils/recommender.py— filterall_projectswithproject_matches_techwhentech_stackis not "all".tests/test_recommender_tech_stack.py— new regression tests asserting the filter changes the result set, all returned projects match the selected stack, and filtered results are a subset of the unfiltered query.Testing
tests/test_recommender_tech_stack.py— 4 passed.projects.jsondataset confirmed the filter now narrows results correctly (e.g.java→ 3 projects all matching,flask→ 4 all matching, previously 30 unfiltered for every value).Closes #1870