Skip to content

fix: apply technology stack filter in recommendations (issue #1870) - #1900

Merged
komalharshita merged 1 commit into
komalharshita:mainfrom
ionfwsrijan:fix/1870-tech-stack-filter
Aug 16, 2026
Merged

fix: apply technology stack filter in recommendations (issue #1870)#1900
komalharshita merged 1 commit into
komalharshita:mainfrom
ionfwsrijan:fix/1870-tech-stack-filter

Conversation

@ionfwsrijan

Copy link
Copy Markdown
Contributor

Problem

The Technology Stack dropdown on the recommendation page has no effect: the same recommendations are returned regardless of the selected stack. project_matches_tech is defined in src/utils/recommender.py but is never called, so the filter added in #936 and previously working via #1285 was silently dropped when the recommender engine was restored.

Fix

Apply project_matches_tech inside get_recommendations: when a non-all tech_stack is selected, filter the loaded projects before scoring, mirroring the original #936 implementation. Projects that do not match the selected stack are excluded from scoring, relevance, and final recommendations.

Files changed

  • src/utils/recommender.py — filter all_projects with project_matches_tech when tech_stack is not "all".
  • tests/test_recommender_tech_stack.py — new regression tests asserting the filter changes the result set, all returned projects match the selected stack, and filtered results are a subset of the unfiltered query.

Testing

  • Isolated test run (seeded SQLite DB, app context): tests/test_recommender_tech_stack.py — 4 passed.
  • Manual experiment against the real projects.json dataset confirmed the filter now narrows results correctly (e.g. java → 3 projects all matching, flask → 4 all matching, previously 30 unfiltered for every value).

Closes #1870

@vercel

vercel Bot commented Aug 11, 2026

Copy link
Copy Markdown

@ionfwsrijan is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@komalharshita
komalharshita merged commit 42d030a into komalharshita:main Aug 16, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Technology Stack filter has no effect - project_matches_tech is never called (regression of #1285/#936)

2 participants