Skip to content

Remove dead GitHub skills modal from /explore - #1897

Merged
komalharshita merged 1 commit into
komalharshita:mainfrom
ionfwsrijan:fix/1858-remove-dead-github-modal
Aug 16, 2026
Merged

Remove dead GitHub skills modal from /explore#1897
komalharshita merged 1 commit into
komalharshita:mainfrom
ionfwsrijan:fix/1858-remove-dead-github-modal

Conversation

@ionfwsrijan

Copy link
Copy Markdown
Contributor

Problem

The "Fetch Skills" button in the GitHub-skills modal on /explore (explore.html:668) has no JavaScript handler anywhere — script.js only binds #btn-show-github, which does not exist on /explore. The modal markup exists at explore.html:646-672 with no trigger to open it, so it is completely dead UI on a public page.

Fix

Remove the dead GitHub modal block (overlay, username input, error div, Fetch Skills and Cancel buttons) from explore.html. The GitHub skill-import feature remains fully available on the homepage (index.html), which is the only page where it is actually wired up (trigger + OAuth flow + addSkill). The script.js modal-binding and OAuth-callback code already guards against missing elements, so no JS changes are needed.

Files changed

  • src/templates/explore.html

Testing

  • GET /explore returns 200; rendered HTML no longer contains the github-modal-overlay markup.
  • No other templates, tests, or JS reference the removed element ids (github-modal-overlay, github-username, github-modal-error, btn-fetch-github, btn-close-github).
  • Full suite: 522 passed, 19 pre-existing unrelated failures, 3 skipped.

Closes #1858

@vercel

vercel Bot commented Aug 11, 2026

Copy link
Copy Markdown

@ionfwsrijan is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc-2026 type:bug Something isn't working labels Aug 11, 2026
@komalharshita
komalharshita merged commit b30b2c8 into komalharshita:main Aug 16, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 'Fetch Skills' button on /explore has no JS handler - modal has no trigger either (dead UI)

2 participants