fix : ensure encryption key is always bytes in PrivacyManager - #1331
Open
tmdeveloper007 wants to merge 1 commit into
Open
fix : ensure encryption key is always bytes in PrivacyManager#1331tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
|
@tmdeveloper007 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Fixed the encryption key initialization in
src/utils/privacy.pyto ensure the key is always bytes before passing toFernet().The previous code used
os.getenv("ENCRYPTION_KEY", Fernet.generate_key()). Sinceos.getenv()always returns a string (or None), ifENCRYPTION_KEYis set as an environment variable,Fernet(string_key)would crash with a TypeError.Fernet.generate_key()returns bytes, but only when the env var is NOT set.Changes Made
src/utils/privacy.py: Changed key initialization to explicitly handle string env vars by encoding them to bytes:Impact it Made
ENCRYPTION_KEYenvironment variable is set as a stringNote
Please assign this PR to the
tmdeveloper007account.Closes #1326