UI Polish: Landing page hero & navbar refinements#1303
Open
saishnimbalkar397 wants to merge 1 commit into
Open
UI Polish: Landing page hero & navbar refinements#1303saishnimbalkar397 wants to merge 1 commit into
saishnimbalkar397 wants to merge 1 commit into
Conversation
|
@saishnimbalkar397 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary [required]
This PR refines the hero section and navigation layout of the DevPath landing page to improve visual hierarchy, interface clarity, and accessibility. Based on a review of the layout, several spacing and contrast adjustments were made. The navigation bar was decluttered to focus on core links, action items were repositioned to match standard user expectations, typography leading was expanded for better readability, and the primary call-to-action button text was updated to a dark color to resolve a low-contrast accessibility issue against the bright yellow background.
Related Issue [required]
Closes #1293
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
index.htmltstyle.cssHow to Test This PR [required]
Clone this branch: git checkout style/ui-refinement
Run the application locally using your development server (e.g., npm run dev or equivalent Vite command).
Open the application in your browser at the local port.
Verify the header layout: confirm "Login with GitHub" is now on the far right and the extra links are removed.
Inspect the "Start Finding Projects" button to ensure the dark text provides readable, accessible contrast against the yellow background.
Check the headline spacing (line-height) to ensure the text flows comfortably.
Test Results [required]
Visual inspection passed across desktop viewports.
Screenshots (if UI change)
| Before | After |
|
|
|
| screenshot | screenshot |
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
Please pay close attention to the text contrast on the primary "Start Finding Projects" button. The new dark text resolves the previous readability issue present in the original layout.