Perf/optimize tfidf - #1233
Merged
Merged
Conversation
|
Someone is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Thanks for the optimization! Moving the tokenization and IDF computation outside the per-project scoring loop is a clean improvement that removes redundant work while keeping the recommendation logic unchanged. The benchmark results clearly demonstrate the performance gains (~15x faster on the provided dataset), and the optimization should scale much better as the project dataset grows. The implementation is well-scoped and focused on performance without introducing unnecessary complexity. Overall, this is a valuable optimization for the recommendation engine. Nice work! 🚀 Approved for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Performance Improvements (Benchmark Results)
I wrote a benchmark script to test the time complexity of
get_recommendationsbefore and after moving the tokenization and_idfscoring outside of the single-project scoring loop.Testing constraints: 22 Projects loaded in the dataset.
Before Optimization (O(N²))
After Optimization (O(N))
📈 Result