Add Open Graph and Twitter meta tags - #118
Closed
jaygaikar-09 wants to merge 5 commits into
Closed
Conversation
|
@jaygaikar-09 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
@jaygaikar-09 do resolve the merge conflicts |
Contributor
Author
|
@komalharshita Done! |
Owner
|
@jaygaikar-09 ensure that all checks pass |
…ix/rich-social-preview-tags-clean2
Contributor
Author
|
@komalharshita Done! |
komalharshita
requested changes
May 24, 2026
komalharshita
left a comment
Owner
There was a problem hiding this comment.
Thanks for the contribution. Adding Open Graph and Twitter metadata is a valuable improvement for SEO and social sharing, and the PR is heading in a good direction.
However, the implementation is currently incomplete and should not be merged yet.
Main concerns:
og:imageandtwitter:imagetags are missing, which are important for proper rich preview rendering on social platforms.- The OG/Twitter metadata was only added to the homepage, while project detail pages still lack equivalent social metadata support.
- The deployment URL is hardcoded directly into the template, which may become problematic for staging/custom domain setups.
- The PR adds
tests/conftest.py, but no actual metadata validation tests were included.
Before this can be approved, please:
- add image metadata tags
- add OG/Twitter metadata support for project pages as well
- consider canonical metadata support
- either document or improve handling of the production URL
- include actual tests validating rendered metadata output
Once the metadata implementation is more complete and consistent across shareable pages, this can be re-reviewed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added Open Graph and Twitter Card meta tags to
templates/index.htmlto improve social sharing previews for the DevPath homepage. These tags provide proper titles and descriptions when links are shared on platforms like Twitter, LinkedIn, Slack, and WhatsApp without affecting layout or functionality.Closes #78
Type of Change
What Was Changed
templates/index.html<head>sectionHow to Test