fix:Hamburger opening issue - #1150
Open
Ash-Misty wants to merge 3 commits into
Open
Conversation
|
@Ash-Misty is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
@Ash-Misty kindly resolve the merge conflicts |
Author
|
solved the conflicts |
Owner
|
@Ash-Misty kindly check again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary [required]
Improved the mobile navigation experience by fixing the misbehavior of hamburger menu drawer. Added a modern slide-in menu with smoother animations, better spacing, improved accessibility, and a dedicated overlay backdrop. The updated design provides a cleaner and more responsive user experience on mobile devices.
Related Issue [required]
Closes #1127
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
|
style.css| Improved spacing and typography for mobile navigation links and made the hamburger menu working ||
index.html| form tag mispplaced ||
script.js| Enhanced hover and focus states for accessibility |How to Test This PR [required]
Checkout this branch:
Run the project locally.
Open the website in a mobile viewport (375px width recommended).
Click the hamburger menu icon.
Verify the drawer slides in smoothly from the right.
Verify the overlay appears behind the menu.
Verify all navigation links remain functional.
Close the menu using the toggle button and by clicking outside the drawer.
Verify the desktop navigation remains unchanged.
Expected Result
Test Results [required]
Screenshots (if UI change)
Self-Review Checklist [required]
style/mobile-menu-redesignNotes for Reviewer
This PR focuses exclusively on visual and UX improvements for the mobile navigation drawer. No business logic or navigation functionality was modified.