Error injection and fixes to resilient OpenMP execution spaces #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmm0
changed the title
nmm0
force-pushed
the
elisabethgiem/resilient-dmr
branch
from
1914fa8
to
0174855
Compare
|
Can you rebase this on main to get the CI fix? |
ElisabethGiem
force-pushed
the
elisabethgiem/resilient-dmr
branch
2 times, most recently
from
2579e4a
to
47cff8d
Compare
…el_for template types correctly in MiniMD
…subscriber naming convention
…ry rebase issues.
ElisabethGiem
force-pushed
the
elisabethgiem/resilient-dmr
branch
from
47cff8d
to
75992b4
Compare
nmm0
requested changes
Nov 13, 2024
| @@ -1,6 +1,9 @@ | |||
| cmake_minimum_required(VERSION 3.17) | |||
| project(kokkos-resilience VERSION 0.1.0) | |||
|
|
|||
| #OLD bheavior is deprecated by definition and may be removed in future | |||
| cmake_policy(SET CMP0144 OLD) | |||
There was a problem hiding this comment.
I think we shouldn't add this
| @@ -10,7 +13,7 @@ add_library(Kokkos::resilience ALIAS resilience) | |||
|
|
|||
|
|
|||
| option(KR_ALL_WARNINGS "Enable all warnings" ON) | |||
| option(KR_WARNINGS_AS_ERRORS "Enable warnings as errors" ON) | |||
| option(KR_WARNINGS_AS_ERRORS "Enable warnings as errors" OFF) | |||
There was a problem hiding this comment.
Let's keep this as on -- if you need to set this to off do so in your configure
| @@ -138,6 +142,22 @@ export(TARGETS resilience | |||
| FILE resilienceTargets.cmake | |||
| ) | |||
|
|
|||
| if (Kokkos_ENABLE_Cuda) | |||
| target_compile_definitions(resilience PUBLIC KR_ENABLE_CUDA) | |||
| @@ -48,6 +48,8 @@ | |||
| #include <iomanip> | |||
| #include <iostream> | |||
|
|
|||
| #include <iostream> | |||
| } | ||
| } | ||
| else{ | ||
| std::cout << "Error finding error_rate. Were global error settings enabled?\n"; |
There was a problem hiding this comment.
I'm not sure we need this output
| KokkosResilience::clear_duplicates_map(); | ||
| #endif | ||
| repeats--; | ||
|
|
||
| }// while (!success & repeats left) |
|
|
||
| repeats--; | ||
|
|
||
| }// while (!success & repeats left) |
|
|
||
| // Range policy implementation | ||
| template <class CombinedFunctorReducerType, class... Traits> | ||
| class ParallelReduce< CombinedFunctorReducerType |
There was a problem hiding this comment.
Is this guy working properly? If not lets omit from the PR
Comment on lines
+103
to
+104
| inline static std::chrono::duration<long int, std::ratio<1, 1000000000>> elapsed_seconds{}; | ||
| inline static std::chrono::duration<long int, std::ratio<1, 1000000000>> total_error_time{}; |
There was a problem hiding this comment.
Suggested change
| inline static std::chrono::duration<long int, std::ratio<1, 1000000000>> elapsed_seconds{}; | |
| inline static std::chrono::duration<long int, std::ratio<1, 1000000000>> total_error_time{}; | |
| inline static std::chrono::duration<long int, std::nano> elapsed_seconds{}; | |
| inline static std::chrono::duration<long int, std::nano> total_error_time{}; |
| inline static size_t global_next_inject = 0; | ||
| }; | ||
|
|
||
| struct ETimer{ |
There was a problem hiding this comment.
Suggested change
| struct ETimer{ | |
| struct ErrorTimerSettings{ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An omnibus PR to bring Kokkos Resilience up to date with execution space work.
Apologies for the mega PR, smaller PRs in the future!