Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused lines #139

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Remove unused lines #139

merged 3 commits into from
Sep 27, 2024

Conversation

yasahi-hpc
Copy link
Collaborator

This PR aims at cleaning up. Following modifications are made.

  • Using new static assertions for operation
  • Remove an unused argument from fft_exec_impl function

@yasahi-hpc yasahi-hpc self-assigned this Sep 24, 2024
tpadioleau
tpadioleau approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me, one question though, the string in the static_assert is quite long, do you think we could factorize this static_assert call into an empty function ?

@yasahi-hpc
Copy link
Collaborator Author

Ok for me, one question though, the string in the static_assert is quite long, do you think we could factorize this static_assert call into an empty function ?

Actually, I am planning to optimize the error messages in #133

@yasahi-hpc yasahi-hpc merged commit d406037 into kokkos:main Sep 27, 2024
20 checks passed
@yasahi-hpc yasahi-hpc deleted the remove-unused-lines branch September 27, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau tpadioleau approved these changes

Assignees

@yasahi-hpc yasahi-hpc

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yasahi-hpc @tpadioleau