Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check View rank and FFT rank consistency #121

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

yasahi-hpc
Copy link
Collaborator

@yasahi-hpc yasahi-hpc commented Jul 23, 2024

Improves #80

This PR aims at applying check between View rank and FFT dimension.
Static assertions are applied to Unary and Binary APIs.
In addition, remove static_assertions from implementation details since we added static_assertions to APIs.

Following changes are made.

  • Introduce new constant MAX_FFT_DIM (= 3) in KokkosFFT_common_types.hpp.
  • Add static_assertion to check that FFT dimension is between 1 and MAX_FFT_DIM (= 3). Some library only supports 1D to 3D FFT.
  • Add static_assertion to check that View::rank() >= FFT dimension.

@yasahi-hpc yasahi-hpc self-assigned this Jul 23, 2024
@yasahi-hpc yasahi-hpc merged commit 5713084 into kokkos:main Jul 24, 2024
19 checks passed
@yasahi-hpc yasahi-hpc deleted the fft-rank-check branch July 24, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants