Document Kokkos::kokkos_swap and associated new public header
#477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnrizzi
reviewed
Dec 19, 2023
| is ``true``. | ||
|
|
||
| 2) Swaps the arrays ``a`` and ``b``. This overload does not participate in | ||
| overload resolution unless ``T2`` is swappable. |
There was a problem hiding this comment.
can we say a little about what is_swappable is? maybe referring to the std https://en.cppreference.com/w/cpp/types/is_swappable?
There was a problem hiding this comment.
We would need to define our own which I was hoping we would not get into.
Also the way things are going (ADL issues) we will have to call Kokkos::swap something else...
dalg24
changed the title
Kokkos::swap and associated new public headerKokkos::kokkos_swap and associated new public header
crtrott
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending on kokkos/kokkos#6678Documenting kokkos/kokkos#6697