feat(provider)!: add provider abstract classes and interfaces #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This will be the base class of all type of providers.
BREAKING CHANGE: Some properties of anime class has changed its name.
BREAKING CHANGE: Some properties of manga class has changed its name.
BREAKING CHANGE: The 'url' property was removed from base interfaces and classes. Now, the 'url' property should be created individually for every interface. This allows us to not to set urls of wrong type of provider.
BREAKING CHANGE: Some properties of the new inherited chapters interfaces will change.
BREAKING CHANGE: Some old properties of the episode interface was renamed to the base properties name.
BREAKING CHANGE: Some old properties of the Manga chapter interface was renamed to the base properties name.
This change allow us to only pass interfaces inherited from the base interfaces.
barrientosvctor
requested review from
koikiss-dev,
TokyoTF,
Zukaritasu and
Mawfyy
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TokyoTF
approved these changes
Jun 6, 2024
Mawfyy
approved these changes
Jun 7, 2024
Zukaritasu
approved these changes
Jun 7, 2024
koikiss-dev
approved these changes
Jun 7, 2024
BREAKING CHANGE: Now, MangaVolume has been inherited from the base BaseChapter class.
|
Graph was successfully deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This pull request change the way you create new providers. Now, all scraper models must be created by inheriting a base scraper model class. Only when creating a new class of a new type of provider.
This pull request causes changes on the interfaces name, classes name and properties name. All name changes will be listed here:
Interfaces
IAnime->IAnimeMediaIManga->IMangaMediaIAnimeSearch->IAnimeResultClasses
Anime->AnimeMediaManga->MangaMediaAnimeSearch->AnimeResultBase providers
Also, this pull request contains base interfaces and classes for the creation of new type of provider class. Listed here:
Interfaces
IBaseMediaIBaseChapterIBaseResultClasses
BaseMediaBaseChapterBaseResultResolves #161