Curl HTTP/3 over SCION#1
Draft
koflin wants to merge 2 commits into
Draft
Conversation
Owner
Author
|
@marcfrei This is my fork of Curl that uses SCION. I've added some instructions above on how to run the examples. |
marcfrei
approved these changes
Jul 24, 2025
| rc = scion_connect(ctx->socket, &ctx->addr.curl_sa_addr, | ||
| (curl_socklen_t)ctx->addr.addrlen, data->set.ia); | ||
| if (rc != 0) { | ||
| printf("scion connect failed: %d\n", rc); |
|
|
||
| DEBUGASSERT(addr->protocol == IPPROTO_UDP); | ||
| result = scion_topology_from_file(topology, data->set.topology_file_path); | ||
| if (result) |
There was a problem hiding this comment.
It should be if(result), right? Everywhere in this file.
| (struct sockaddr *)&remote_addr, | ||
| &remote_addrlen, NULL, NULL); | ||
| if(nread < 0) { | ||
| if (nread == SCION_WOULD_BLOCK) { |
koflin
commented
Jul 26, 2025
| if (ctx->transport == TRNSPRT_QUIC) { | ||
| socket_close_scion(data, cf->conn, !ctx->accepted, ctx->sock, ctx->socket); | ||
| scion_network_free(ctx->network); | ||
| scion_topology_free(ctx->topology); |
Owner
Author
There was a problem hiding this comment.
do network and topology cleanup in socket_close_scion
koflin
commented
Jul 26, 2025
|
|
||
| *psent = 0; | ||
|
|
||
| sent = scion_send(qctx->socket, |
Owner
Author
There was a problem hiding this comment.
use scion_sendmsg for this
koflin
commented
Jul 26, 2025
|
|
||
| DEBUGASSERT(max_pkts > 0); | ||
| for(pkts = 0, total_nread = 0; pkts < max_pkts;) { | ||
| nread = scion_recvfrom(qctx->socket, (char *)buf, bufsize, MSG_DONTWAIT, |
This was referenced Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for sending HTTP/3 requests over SCION.
Make sure you have installed a release build of csnet (i.e., it has to be configured with
-DCMAKE_BUILD_TYPE=Release)To build CURL do the following:
After building CURL, start the example HTTP/3 server:
To make a request to the example server you can either run the http3 SCION example
or you can use the built CURL executable and run: