Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: version 2 #429

Merged
merged 23 commits into from
Sep 4, 2023
Merged

refactor: version 2 #429

merged 23 commits into from
Sep 4, 2023

Conversation

grikomsn
Copy link
Member

@grikomsn grikomsn commented Aug 28, 2023

Closes #69 #70 #71

@grikomsn grikomsn requested a review from r17x August 28, 2023 18:23
@grikomsn grikomsn self-assigned this Aug 28, 2023
@grikomsn grikomsn marked this pull request as ready for review August 28, 2023 18:28
@grikomsn grikomsn removed a link to an issue Aug 28, 2023
This was referenced Aug 28, 2023
@@ -1,79 +1,44 @@
{
"name": "@kodingdotninja/chakra-icons",
"version": "0.0.0",
"workspaces": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is will be impacted with multi-semantic-release. But I want to find another solutions for handle release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could restore the workspaces field

@r17x
Copy link
Contributor

r17x commented Aug 29, 2023

I will try this change in my local. Thanks @grikomsn

@r17x
Copy link
Contributor

r17x commented Aug 30, 2023

Ship it @grikomsn

.gitignore Show resolved Hide resolved
@grikomsn grikomsn requested a review from r17x September 3, 2023 20:52
Copy link
Contributor

@r17x r17x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, ship it

@grikomsn grikomsn merged commit 0e8fbb4 into main Sep 4, 2023
@r17x r17x deleted the refactor/v2 branch September 8, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project structure housekeeping Offload search API route Update documentation grammars and wordings
2 participants