-
-
Notifications
You must be signed in to change notification settings - Fork 205
feat(mfa): replace trench based API endpoints, views and forms with allauth implementation DEV-749 #6402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…auth authenticators
…tor and fix issues
noliveleger
requested changes
Nov 7, 2025
### Description The MFA token authentication form is replaced by a version based on allauth MFA feature.
### 💭 Notes The trench MFA data is copied to the allauth Authenticator and the MfaMethodsWrapper models in order to remove the trench dependency. In order to avoid disabling MFA for users it migrates the user MFA data from trench when the user logs in. It also includes a long running migration to migrate users MFA data in the background.
noliveleger
approved these changes
Nov 14, 2025
Contributor
noliveleger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Checklist
#Support Docs Updates, if any<type>(<scope>)<!>: <title> DEV-1234Front endand/orBack endorworkflowSummary
Migrate MFA features from Trench to Django Allauth for better integration, maintainability.
Description
This update replaces all Trench-based multi-factor authentication (MFA) endpoints, views, and forms with a new implementation powered by Django Allauth. The change ensures tighter integration with the existing authentication system, simplifies configuration, and improves long-term maintainability.
💭 Notes
The MFA endpoints were changed to use the allauth MFA feature and removing trench. This covers these endpoints that are used in the frontend:
These are now based on the Authenticator model, which can handle TOTP codes and recovery codes.
👀 Preview steps
These endpoints are covered in unit tests, so no need to test. However we could test the following sequence to validate it's working ok: