Fix method call in example to be PHP-like#44
Open
jaroslavtyc wants to merge 1 commit intoknpuniversity:masterfrom
Open
Fix method call in example to be PHP-like#44jaroslavtyc wants to merge 1 commit intoknpuniversity:masterfrom
jaroslavtyc wants to merge 1 commit intoknpuniversity:masterfrom
Conversation
Fix method call in example to be PHP-like instead of JS-like. BTW note somewhere that it mimic jQuery interface plus some "equal to jQuery" example would be helpful for newbies.
| a ``NodeElement``, you can find more elements deeper inside of it:: | ||
|
|
||
| $spanEle = $anchorElement.find('css', 'span.emph'); | ||
| $spanEle = $anchorElement->find('css', 'span.emph'); |
Member
There was a problem hiding this comment.
I would also fix the var name to $anchorEle to match the var name from the above... or even better fix the var name above to $anchorElement instead. Wdyt?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix method call in example to be PHP-like instead of JS-like.
BTW note somewhere that it mimic jQuery interface plus some "equal to jQuery" example would be helpful for newbies.