Android fixes #4223
Closed
Android fixes #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 18, 2021 15:02
…using trouble with REST serializer library reflection trying to ask for methods of missing classes.
|
There are actually a few more classes extending HashMap or ArrayList in coinmate codebase that need removing. |
|
Learning more about codebase, I will submit better PRs later.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to run simple services on coinmate using android API 23. Run into a few problems, that I had to solve.
Coinmate fix is imho good to merge even without it being necessary to run (no reason for REST interface to contain HashMaps).
Core change (ThreadLocal.withInitial) is up for debate. Maybe this simpler version could run into a race condition, haven't really checked.
#4216