home work #16
Open
home work #16
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AviadP
suggested changes
Dec 8, 2019
| @@ -0,0 +1,28 @@ | |||
| file = open("C:/Users/tomer/PycharmProjects/HomeChallenge3/Readme.txt") | |||
| words = open("C:/Users/tomer/PycharmProjects/HomeChallenge3/Readme.txt").read().split() | |||
There was a problem hiding this comment.
there is no need to open file twice. "file" variable declared adlready
| words = open("C:/Users/tomer/PycharmProjects/HomeChallenge3/Readme.txt").read().split() | ||
|
|
||
| print(file.read()) | ||
| print(words) |
| print(words) | ||
|
|
||
|
|
||
| def keywithmaxval(d): |
There was a problem hiding this comment.
use '_' between word - should looks like: key_with_max_val
also, argument name should have some meaning, 'd' is not an acceptable argument name
|
|
||
|
|
||
| def keywithmaxval(d): | ||
| """ a) create a list of the dict's keys and values; |
There was a problem hiding this comment.
docstring should contain:
- general description of the function
- arguments - brief description and their type
- returns - brief description and their type
|
|
||
| print("max word is:", (word_count(words))) | ||
| print(file.read()) | ||
| file.close() |
There was a problem hiding this comment.
using context manager( with...open...) is much better way to handle files operations. in case program will exit on error, file might remain opened
| return keywithmaxval(counts), max(counts.values()) | ||
|
|
||
|
|
||
| print("max word is:", (word_count(words))) |
There was a problem hiding this comment.
it is better using "main" function, that calling other functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.